fix(chain): change max gas price #4382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bowenwang1996
requested review from
Longarithm,
EgorKulikov,
abacabadabacaba and
mzhangmzz
EgorKulikov
reviewed
Jun 21, 2021
| std::cmp::min(self.max_gas_price, 10 * self.min_gas_price(protocol_version)) | ||
| std::cmp::min( | ||
| self.max_gas_price, | ||
| Self::MAX_GAS_MULTIPLIER * self.min_gas_price(protocol_version), |
There was a problem hiding this comment.
Not likely to matter, but maybe do checked multiplication?
There was a problem hiding this comment.
well we know the constants here and they will not cause overflow
EgorKulikov
approved these changes
Jun 21, 2021
Longarithm
approved these changes
Jun 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #4348 we set the maximum gas price to be 10 * minimum gas price. However, one issue with this change is that it changes max gas price to be 10^9 yotcoNEAR, which means that per block max cost is 1N (10^9 yotcoNEAR/gas * 10^15 gas) and this means in a year the maximal burnt tokens in transaction fees is ~31 million NEAR, which will still be smaller than the total inflation (~50 million NEAR). This PR changes the multiplier to 20x to ensure that the network at least does not inflate at maximal capacity.
Note that not changing nightly protocol version is intentional here -- there is no congestion on betanet anyways and we don't need to do a hard fork there.
Test plan
Existing tests.