Add metrics related to the epoch, sync state and node version #6004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Protocol version supported by the node * DB version expected by the node * Header head to complement the existing "block head" metric * Sync status of the node * And the expected height of the protocol upgrade
# Conflicts: # nearcore/src/runtime/mod.rs
nikurt
requested review from
bowenwang1996,
chefsale,
khorolets,
mm-near and
mzhangmzz
as code owners
mzhangmzz
reviewed
Jan 7, 2022
| pub static PROTOCOL_UPGRADE_BLOCK_HEIGHT: Lazy<IntGauge> = Lazy::new(|| { | ||
| try_create_int_gauge( | ||
| "near_protocol_upgrade_block_height", | ||
| "Estimated block height of the protocol upgrade", |
There was a problem hiding this comment.
Just curious, what's the purpose for this metric?
There was a problem hiding this comment.
It lets validators set alerts about an imminent protocol upgrade. Multiple validators expressed interest in this alert.
# Conflicts: # chain/client/src/client_actor.rs # chain/client/src/info.rs # chain/client/src/metrics.rs
bowenwang1996
approved these changes
Jan 7, 2022
mzhangmzz
approved these changes
Jan 10, 2022
chefsale
approved these changes
Jan 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the following metrics to the node: