peer_store: apply IP blacklist to peer store #6503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When reading peers from the storage mark all peers whose address is present in the blacklist as banned. Furthermore, when getting peers from other peers, ignore all peers that are on our blacklist. Previously the blacklist was taken into account when peer tried to establish a new connection with the node. If a peer was already stored in the database or another peer sent us the peer, the node might try to connect to it even if it’s on the blacklist. With this change, if a node is on a blacklist we will no longer try to connect to it.
pompon0
reviewed
Mar 29, 2022
pompon0
reviewed
Mar 29, 2022
pompon0
reviewed
Mar 29, 2022
pompon0
reviewed
Mar 29, 2022
pompon0
approved these changes
Mar 30, 2022
mm-near
approved these changes
Mar 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reading peers from the storage mark all peers whose address
is present in the blacklist as banned. Furthermore, when getting
peers from other peers, ignore all peers that are on our blacklist.
Previously the blacklist was taken into account when peer tried to
establish a new connection with the node. If a peer was already
stored in the database or another peer sent us the peer, the node
might try to connect to it even if it’s on the blacklist. With this
change, if a node is on a blacklist we will no longer try to connect
to it.