Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix authority keys, NAT network, sync & produce blocks integration works #653

Merged
merged 25 commits into from Mar 2, 2019
Merged

Fix authority keys, NAT network, sync & produce blocks integration works #653

merged 25 commits into from Mar 2, 2019

Conversation

ilblackdragon
Copy link
Member

Start by launching consensus from the last block.

ilblackdragon and others added 12 commits March 2, 2019 15:14
@ilblackdragon
Piping proper block signing keys in proper places via Signer trait. I…
ce0f5e9 
…nMemorySigner::from_seed creates keys from a seed. Block producing key files (the one that loads by default) contain both BLS and ED25591 keys for block signing.
Fix receipt block propagation
b08dd47
@ilblackdragon
Finished piping signer. Split Signer into TransactionSigner and Block…
f169906 
…Signer.
@ilblackdragon
Clean up old types
a20f828
@ilblackdragon
Remove UID!!!!
c605bbf
@ilblackdragon
Add ability to handle nodes without public addresses
49ea681
@ilblackdragon
Fix rest of tests/benches.
8ea4953
@ilblackdragon
Merge remote-tracking branch 'origin/master' into authority-fix
f2a4cce
@ilblackdragon
Merge branch 'authority-fix' into network-nat
24a5a84
@ilblackdragon
Fix tests
dbe6166
@ilblackdragon
Merge remote-tracking branch 'origin/fix_receipts' into make-alphanet…
5be739c 
…-work
@ilblackdragon
Towards 3 nodes working
e7e6422
@MaksymZavershynskyi MaksymZavershynskyi mentioned this pull request Mar 2, 2019
Closed
@MaksymZavershynskyi
Copy link
Contributor

So this code seems to be mostly #651. LGTM for that part.
I think this PR needs to have a more specific name, by I cannot come up with anything good.

This was referenced Mar 2, 2019
Closed
Merged
@ilblackdragon ilblackdragon changed the title [WIP] Make alphanet work Fix authority keys, NAT network, sync & produce blocks integration works Mar 2, 2019
@MaksymZavershynskyi
Copy link
Contributor

So the way it solved the problem with NAT is by allowing nodes to specify their PeerInfo::addr as None. Correct?

@MaksymZavershynskyi
Copy link
Contributor

Also, if I understood correctly you are saying this fixes this issue?

thread 'tokio-runtime-worker-4' panicked at 'Threshold is not found for given proposals: "Total stake 0 must be higher than the number of seats 2"', src/libcore/result.rs:1009:5

What is the fix, and why was it failing?

@ilblackdragon
Copy link
Member Author

@nearmax

For network stuff: yeah, it's not really solving NAT, just allows nodes without public addresses to connect to the network. addr is option and if it's not present, peer.rs doesn't try to connect to it.

For authorities, the problem was that we didn't have authority_mask populated at all (so everybody got kicked out). The real fix will be in #645 but I just filled in with true for now for all authorities.

@ilblackdragon ilblackdragon merged commit 2f5a038 into master Mar 2, 2019
@bowenwang1996 bowenwang1996 deleted the make-alphanet-work branch March 14, 2019 17:19
@ilblackdragon ilblackdragon added this to the AlphaNet milestone Mar 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaksymZavershynskyi MaksymZavershynskyi MaksymZavershynskyi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
AlphaNet
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ilblackdragon @MaksymZavershynskyi