Prefer lazy_static_include_bytes in tests #6654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently lazy_static_include_bytes compiles faster than include_bytes and we’re already using it in bunch of tests so do that consistently.
matklad
approved these changes
Apr 21, 2022
There was a problem hiding this comment.
This is an improvement! Though, I'd just std::fs::read in tests, to avoid using what we don't need (namely, for tests it's irrelevant that in --release this turns out into include!. It's actually slightly harmful, as we care about build time of cargo test --release a bit as well)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently lazy_static_include_bytes compiles faster than include_bytes
and we’re already using it in bunch of tests so do that consistently.