Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use consistent field name for error #6882

Merged
merged 3 commits into from
May 25, 2022
Merged

refactor: use consistent field name for error #6882

merged 3 commits into from
May 25, 2022

Conversation

matklad
Copy link
Contributor

@matklad matklad commented May 25, 2022

Most of the code uses ?err, rather than error, so let's use it here
as well, to make jqing for field easier.

@matklad
refactor: use consistent field name for error
12a29ec 
Most of the code uses `?err`, rather than `error`, so let's use it here
as well, to make jqing for field easier.
@matklad matklad requested a review from a team as a code owner May 25, 2022 11:44
@matklad matklad requested review from mina86 and nikurt and removed request for mina86 May 25, 2022 11:44
@matklad
Copy link
Contributor Author

matklad commented May 25, 2022

Should we use error rather than err? Maybe, but mostly I think it doesn't matter, and being consistent here seems more important.

@near-bulldozer near-bulldozer bot merged commit 48a1ebb into near:master May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikurt nikurt nikurt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@matklad @nikurt