Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove impossible-to-trigger panic #7013

Merged
merged 2 commits into from
Jun 10, 2022
Merged

chore: remove impossible-to-trigger panic #7013

merged 2 commits into from
Jun 10, 2022

Conversation

Ekleog
Copy link
Contributor

@Ekleog Ekleog commented Jun 10, 2022

This panic both never triggered and broke the API constraints of
BorshDeserialize. See the discussion at [1]

[1] #6186

fixes #6186

@Ekleog
chore: remove impossible-to-trigger panic
1dd4443 
This panic both never triggered and broke the API constraints of
BorshDeserialize. See the discussion at [1]

[1] near#6186

fixes near#6186
@Ekleog Ekleog requested a review from a team as a code owner June 10, 2022 11:13
@Ekleog Ekleog requested a review from matklad June 10, 2022 11:13
@Ekleog Ekleog mentioned this pull request Jun 10, 2022
Closed
@near-bulldozer near-bulldozer bot merged commit 3c46445 into near:master Jun 10, 2022
nikurt pushed a commit that referenced this pull request Jun 13, 2022
@Ekleog @nikurt
chore: remove impossible-to-trigger panic (#7013)
8116043 
This panic both never triggered and broke the API constraints of
BorshDeserialize. See the discussion at [1]

[1] #6186

fixes #6186
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matklad matklad matklad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Suspicious unwrap in Account's deserialize
2 participants
@Ekleog @matklad