Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store: add StoreConfig::migration_snapshot option; deprecated options in Config #7486

Merged
merged 5 commits into from
Aug 29, 2022

Conversation

mina86
Copy link
Contributor

@mina86 mina86 commented Aug 26, 2022

Deprecated use_db_migration_snapshot and db_migration_snapshot_path
fields in Config by migration_snapshot field in StoreConfig. The main
motivation for doing it is being able to configure the path separately
for hot and cold storage (once cold storage is implemented).

… in Config

Deprecated use_db_migration_snapshot and db_migration_snapshot_path
fields in Config by migration_snapshot field in StoreConfig.  The main
motivation for doing it is being able to configure the path separately
for hot and cold storage (once cold storage is implemented).
@mina86 mina86 requested a review from a team as a code owner August 26, 2022 17:21
Copy link
Contributor

@nikurt nikurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Please also update https://near-nodes.io/maintenance/db-migrations or create an issue to update it once your change gets released.

mina86 added a commit to near/node-docs that referenced this pull request Aug 29, 2022
@near-bulldozer near-bulldozer bot merged commit 6b9aff9 into near:master Aug 29, 2022
@mina86 mina86 deleted the d branch August 29, 2022 22:01
mina86 added a commit to near/node-docs that referenced this pull request Aug 30, 2022
nikurt pushed a commit that referenced this pull request Nov 9, 2022
… in Config (#7486)

Deprecated use_db_migration_snapshot and db_migration_snapshot_path
fields in Config by migration_snapshot field in StoreConfig.  The main
motivation for doing it is being able to configure the path separately
for hot and cold storage (once cold storage is implemented).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants