-
Notifications
You must be signed in to change notification settings - Fork 586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC: one mdBook to rule them all #7653
RFC: one mdBook to rule them all #7653
Conversation
2c957ac
to
1d66818
Compare
This is absolutely brilliant. I am in full support for moving full steam ahead on this. |
how did you upload the images? |
I don't think this is absolutely brilliant, there's certainly some drawbacks:
Yeah, this is an important bit. For .svg illustrations, I put them in the media folder. I think we probably should try to stick to .svg as possible. For .png illustrations, it would be possble to put them in media, but I'd rather not. I think it's important to try to keep repo size reasonable. So I use my standard trick here: host images on github: matklad#2 And yeah, this is the policy I'd love to propose:
|
Worth noting that SVG isn’t always quite lightweight either. And unfortunately making modifications to an SVG will likely result in a non-trivial diff, unless the change is made by modifying the XML directly. In the past for things like graphs I used Overall, I have had quite a good experience with mdbook personally, so 👍 from me on the general direction. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is epic! I like the name of the branch :)
Until we catchup to the gc_stop. | ||
|
||
|
||
(the original drawings for this document are here: <https://docs.google.com/document/d/1BiEuJqm4phwQbi-fjzHMZPzDL-94z9Dqkc3XPNnxKJM/edit?usp=sharing>) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This document isn't publicly accessible right? Should we remove the link?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, we should do something here once we actually merge this stuff, I choose not to think about this yet.
That being said, I suggest not worrying about leaving some links to private stuff:
- this should be low-effort-to-write kind of docs
- if link is broken for someone, they'll bug us
Chatted with marcin about images, the current solution is OK. So, I consider the RFC accepted and would move to implementation work, which is tracked at #7670 |
In this PR, I want to draft how we could centralize all our dev docs in a single, publicly accessible and publicly editable location.
In this PR I want us to agree on:
To this end I:
See the rendered version here: https://matklad.github.io/nearcore/
Note the edit button as well: