themis: publishable crates shouldn't depend on non-publishable ones #7707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matklad
approved these changes
Sep 27, 2022
near-bulldozer
bot
deleted the
themis-ensure-recursively-publishable
branch
frol
approved these changes
Sep 28, 2022
| } | ||
| if !outliers.is_empty() { | ||
| bail!(ComplianceError { | ||
| msg: "These private packages are depended on by publishable packages".to_string(), |
There was a problem hiding this comment.
The original message was hard to understand at the first glance, so I tried to rewrite it. What do you think?
Suggested change
| msg: "These private packages are depended on by publishable packages".to_string(), | |
| msg: "These private crates break publishable crates. Either make these private crates publishable or avoid using them in the publishable crates.".to_string(), |
There was a problem hiding this comment.
Yeah, this makes sense. I, too, went through a couple of description iterations, the above happened to be the shortest with most clarity, but I agree that we don't need to optimize for length, so more descriptive (and in this case, suggestive) is good. If you can submit a PR to this effect, that'd be awesome.
near-bulldozer bot
pushed a commit
that referenced
this pull request
Sep 29, 2022
…ublishable crates depend on private crates (#7720) The original message was hard to understand at a first glance. #7707 (comment)
nikurt
pushed a commit
that referenced
this pull request
Nov 9, 2022
…7707) #7680 bumped the version of non-private crates to `0.15.0`. Unfortunately, the publish process failed, because `near-o11y` which is marked as a private package, is depended on by `near-vm-logic`, which is a non-private crate. This adds a check to `themis`, to ensure we never get this kind of discrepancy merged into master. Example Report: <img width="498" alt="CleanShot 2022-09-27 at 19 53 10@2x" src="https://user-images.githubusercontent.com/16881812/192575063-93c35ffb-e01e-41d9-8d4a-2d904ae85409.png">
nikurt
pushed a commit
that referenced
this pull request
Nov 9, 2022
…ublishable crates depend on private crates (#7720) The original message was hard to understand at a first glance. #7707 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#7680 bumped the version of non-private crates to
0.15.0. Unfortunately, the publish process failed, becausenear-o11ywhich is marked as a private package, is depended on bynear-vm-logic, which is a non-private crate.This adds a check to
themis, to ensure we never get this kind of discrepancy merged into master.Example Report: