Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trace context for the following actors: #7819

Merged
merged 32 commits into from
Oct 18, 2022
Merged

Trace context for the following actors: #7819

merged 32 commits into from
Oct 18, 2022

Conversation

nikurt
Copy link
Contributor

@nikurt nikurt commented Oct 13, 2022 •
edited

  • ClientActor
  • ViewClientActor
  • TelemetryActor

Tested by running a mainnet node with this PR.

This PR enriches the tracing information. With this change we can see which context generated the actix messages processed by ClientActor and ViewClientActor.
https://pagodaplatform.atlassian.net/browse/ND-171

@nikurt nikurt marked this pull request as ready for review October 14, 2022 11:12
@nikurt nikurt requested a review from a team as a code owner October 14, 2022 11:12
@nikurt nikurt requested review from mzhangmzz and nagisa and removed request for mzhangmzz October 14, 2022 11:12
nagisa
nagisa reviewed Oct 14, 2022
View reviewed changes
chain/client/src/client_actor.rs Outdated Show resolved Hide resolved
chain/client/src/tests/bug_repros.rs Outdated Show resolved Hide resolved
chain/client/src/tests/catching_up.rs Outdated Show resolved Hide resolved
chain/client/src/view_client.rs Outdated Show resolved Hide resolved
nikurt and others added 14 commits October 17, 2022 16:26
@nikurt
Define a macro to avoid repeating the debug span construction.
b86133e
@matklad @nikurt
refactor: remove dead code (#7814)
52c4f6d
@Ekleog-NEAR @nikurt
Fuzz the running releases (#7833)
a551dcf
@robin-near @nikurt
[TransactionResult] Avoid panicing if original column had duplicate e…
72eb367 
…ntries (#7835)

https://near.zulipchat.com/#narrow/stream/295558-pagoda.2Fcore/topic/DB.20migrate_32_to_33.20panics

That's the only reason I could think of.
@matklad @akhi3030 @nikurt
docs: move epoch docs from confluence (#7838)
4ed97af 
Co-authored-by: Akhilesh Singhania <akhi3030@gmail.com>
@matklad @nikurt
docs: move sync docs from confluence (#7837)
be859da
@mina86 @nikurt
nearcore: run node in archival mode if database is an archive (#7752)
f5bc84a 
Previously, if neard wasn’t configured to run as an archival node
(i.e. `archive` setting in `config.json` was false) but the database
was an archive, the node would fail.  Change this behaviour so that it
warns and continues running as archival node.

The grand plan is to get rid of the `archive` setting and have type of
the node be determined by the database.  This will reduce number of
special cases to be handled when opening a database.
@mina86 @nikurt
client: add {node,validator}_public_key field to /status response; de…
50e4cea 
…precated node_key (#7828)

Currently, response to the /status request returns a `node_key`
field. However, the field does not include node key but rather
validator key.  Deprecated it in favour of two new fields:
`node_public_key` and `validator_public_key`.

Fixes: #7672
@nikurt
fix(o11y): Write all logs to stderr (#7834)
292ac32 
Thanks to @marcelo-gonzalez for providing the diff.
@matklad @nikurt
refactor: move get_validator_info to EpochManagerAdapter (#7727)
f6f02fa 
part of #6910, depends on #7726
@mina86 @nikurt
chain: don’t clone Store in RuntimeAdapter::get_store (#7841)
afd600d 
Replace RuntimeAdapter::get_store with RuntimeAdapter::store method
which returns reference to a Store rather than cloning it.  This
avoids some instances where the Store is cloned unnecessarily.
@nikurt
Trace context for the following actors:
a6783f7 
* ClientActor
* ViewClientActor
* TelemetryActor
@nikurt
fmt
e67da3a
@nikurt
Merge
d64ffb7
@nikurt nikurt requested a review from nagisa October 17, 2022 15:00
nagisa
nagisa reviewed Oct 18, 2022
View reviewed changes
chain/network/src/peer/peer_actor.rs Outdated Show resolved Hide resolved
chain/client/src/client_actor.rs Outdated Show resolved Hide resolved
chain/client/src/client_actor.rs Outdated Show resolved Hide resolved
chain/client/src/tests/bug_repros.rs Outdated Show resolved Hide resolved
@nagisa
Copy link
Collaborator

nagisa commented Oct 18, 2022

This is looking pretty clean so far! I love when the code becomes clearer as a result of adding functionality ^^

@nikurt nikurt requested a review from nagisa October 18, 2022 13:14
nagisa
nagisa approved these changes Oct 18, 2022
View reviewed changes
Copy link
Collaborator

@nagisa nagisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, last two remaining nits, feel free to not fix them right now if my nits are getting annoying ^^

core/o11y/src/macros.rs Outdated Show resolved Hide resolved
core/o11y/src/macros.rs Outdated Show resolved Hide resolved
@near-bulldozer near-bulldozer bot merged commit 702c25c into master Oct 18, 2022
@near-bulldozer near-bulldozer bot deleted the nikurt-viewca-context branch October 18, 2022 14:17
nikurt added a commit that referenced this pull request Nov 9, 2022
@nikurt
Trace context for the following actors: (#7819)
f21e049 
* ClientActor
* ViewClientActor
* TelemetryActor

Tested by running a mainnet node
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nagisa nagisa nagisa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@nikurt @nagisa @matklad @Ekleog-NEAR @robin-near @mina86