chore: upgrade rust-version to 1.65.0 #7993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- GATs are finally here! I'd be surprised if we cannot make use of it. - stabilized `std::backtrace::Backtrace`, we should see if we can remove our `backtrace` dependency now - let else statements are now a thing
matklad
approved these changes
Nov 4, 2022
matklad
reviewed
Nov 4, 2022
| @@ -4,7 +4,7 @@ version = "0.0.0" | |||
| publish = false | |||
| authors = ["Near Inc <hello@nearprotocol.com>"] | |||
| # Please update rust-toolchain.toml as well when changing version here: | |||
| rust-version = "1.64.0" | |||
| rust-version = "1.65.0" | |||
There was a problem hiding this comment.
drive by, but specifying rust-version for test contracts doesnt' really makes sense, these crates shond basically never be published to crates.io
There was a problem hiding this comment.
would you suggest to just leave it unspecified? i.e. just delete this line?
There was a problem hiding this comment.
Yeah, that'd be better, but we also need to make sure that themis doesn't complain.
nikurt
pushed a commit
that referenced
this pull request
Nov 7, 2022
- GATs are finally here! I'd be surprised if we cannot make use of it. - stabilized `std::backtrace::Backtrace`, we should see if we can remove the `backtrace` dependency - let else statements are now a thing
nikurt
pushed a commit
that referenced
this pull request
Nov 9, 2022
- GATs are finally here! I'd be surprised if we cannot make use of it. - stabilized `std::backtrace::Backtrace`, we should see if we can remove the `backtrace` dependency - let else statements are now a thing
near-bulldozer bot
pushed a commit
that referenced
this pull request
Jan 6, 2023
https://blog.rust-lang.org/2022/12/15/Rust-1.66.0.html Updated the same files as in the previous version bump: #7993 This enables #7650 (see [this comment](#7650 (comment))). Also includes fixes for the following warning: ``` warning: for loop over an `Option`. This is more readably written as an `if let` statement ... = note: `#[warn(for_loops_over_fallibles)]` on by default ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std::backtrace::Backtrace, we should see if we can removethe
backtracedependency