Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: estimator metrics #8010

Merged
merged 2 commits into from Nov 8, 2022
Merged

docs: estimator metrics #8010

merged 2 commits into from Nov 8, 2022

Conversation

jakmeier
Copy link
Contributor

@jakmeier jakmeier commented Nov 8, 2022

A small additions to docs that explains the --metric argument and
helps understanding the results the estimator produces.

@jakmeier
docs: estimator metrics
adaf08e 
A small additions to docs that explains the `--metric` argument and
helps understanding the results the estimator produces.
@jakmeier jakmeier requested a review from matklad November 8, 2022 11:12
@jakmeier jakmeier requested a review from a team as a code owner November 8, 2022 11:12
matklad
matklad approved these changes Nov 8, 2022
View reviewed changes
Copy link
Contributor

@matklad matklad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but, as an alternaive, maybe remove the --metric argument and always collect all available metrics?

@jakmeier
Copy link
Contributor Author

jakmeier commented Nov 8, 2022 •
edited

LGTM, but, as an alternaive, maybe remove the --metric argument and always collect all available metrics?

I agree that we should clean up the arguments here. But I am not sure if removing metric is the right choice, I mean yes we can collect both but what do we report? Both? I would argue reporting wall-clock within qemu is just flat out wrong, qemu emulated time makes no sense to me. Also, icount without qemu is impossible anyway, so maybe we should keep --metric but implicitly select --docker when necessary? (that is, remove --docker)

@near-bulldozer near-bulldozer bot merged commit bdabb81 into near:master Nov 8, 2022
@jakmeier jakmeier deleted the doc-estimator-metrics branch November 8, 2022 15:31
@matklad
Copy link
Contributor

matklad commented Nov 8, 2022

but what do we report?

If icount worked, report that, otherwise report time?

nikurt pushed a commit that referenced this pull request Nov 9, 2022
@jakmeier @nikurt
docs: estimator metrics (#8010)
27e96ba 
A small additions to docs that explains the `--metric` argument and
helps understanding the results the estimator produces.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matklad matklad matklad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jakmeier @matklad