Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: stabilize meta transactions NEP-366 #8601

Merged
merged 2 commits into from
Feb 20, 2023

Conversation

jakmeier
Copy link
Contributor

@jakmeier jakmeier requested a review from a team as a code owner February 20, 2023 12:17
@jakmeier
Copy link
Contributor Author

@akhi3030 this would be the other PR we want merged before I can publish near-primitives.

This brings in all the meta transaction features to stable. To state this obvious: This is a protocol change.

However, code-wise, this should be a boring PR. Just the normal stabilization steps:

  • remove all the cfg
  • protocol version bump (was already done for other features)
  • move the protocol feature DelegateAction to version stable 59.
  • update gas snapshots for version 59 (in separate commit for easier review)

Two additional small things to take note of:

  • I delete the test test_delegate_action_deserialization that has some comments regarding deserialization and protocol versions. This case is now tested in reject_valid_meta_tx_in_older_versions which was already implemented previously, I just forgot to delete the old test.
  • Rosetta RPC currently ignores delegate actions. Rational is that nobody except known partners us the Rosetta RPC. They don't run it on testnet. Therefore we can wait a bit longer to get this done. Tracked in implement rosetta rpc adapter for delegate action #8469 . Eitherway, it doesn't affect the protocol and doesn't need to be linked with the stabilization PR.

@akhi3030
Copy link
Collaborator

Andrei has agreed to do an initial review here.

Copy link
Collaborator

@akashin akashin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes make sense to me.

core/primitives/src/transaction.rs Show resolved Hide resolved
runtime/runtime/src/actions.rs Show resolved Hide resolved
Copy link
Collaborator

@akhi3030 akhi3030 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review Andrei. Approving to unblock merging.

@jakmeier
Copy link
Contributor Author

Thanks for the reviews, I will go ahead and merge this in a few minutes.

@jakmeier jakmeier merged commit f7a6bd4 into near:master Feb 20, 2023
@jakmeier jakmeier deleted the meta-tx-stabilize branch February 20, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants