Only store transactions on validator nodes #8965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akashin
force-pushed
the
tp_non_validator
branch
2 times, most recently
from
b5a65b9
to
d397408
Compare
akashin
force-pushed
the
tp_non_validator
branch
from
d397408
to
8a2bc47
Compare
nikurt
approved these changes
Apr 24, 2023
Yes, I want to address the unbounded accumulation of transactions in the pool for all types of nodes, though I'm still trying to understand the flow of transactions in more detail and especially what will happen during the high load, so it's hard for me to formulate how the final solution will look like just yet. |
akashin
added
the
A-congestion
nikurt
pushed a commit
that referenced
this pull request
Apr 25, 2023
nikurt
pushed a commit
that referenced
this pull request
Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment transactions are indefinitely stored on RPC nodes that are not validators (#8878, #6713).
The intent of this commit is to avoid storing transactions on any node that can't be a chunk/block producer and as far as I understand, such node requires a validator key, so we use it as a condition to store the transaction.