fix two bugs that regarding verifying shard_id #8977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nagisa
reviewed
Apr 26, 2023
| @@ -1107,6 +1107,9 @@ impl Chain { | |||
| byzantine_assert!(false); | |||
| return Err(Error::InvalidChunk); | |||
| } | |||
| if chunk_header.shard_id() != shard_id as ShardId { | |||
There was a problem hiding this comment.
Consider ShardId::from(shard_id). Or ShardId::try_from(shard_id) with appropriate handling.
There was a problem hiding this comment.
Will fix it in a follow up PR. I need to add tests for this PR later. We needed to merge it asap for the release.
bowenwang1996
approved these changes
Apr 26, 2023
nikurt
pushed a commit
that referenced
this pull request
Apr 28, 2023
Co-authored-by: Bowen Wang <bowenwang1996@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.