feat: implement chunk validator assignment #9983
Conversation
mooori
force-pushed
the
chunk-validator-assignment
branch
from
b243fb4
to
f32715b
Compare
mooori
force-pushed
the
chunk-validator-assignment
branch
from
f32715b
to
20d225f
Compare
|
I'm not too familiar with this topic. |
wacban
requested review from
pugachAG,
Longarithm and
robin-near
and removed request for
wacban
core/primitives/src/epoch_manager.rs
Outdated
| @@ -615,6 +656,28 @@ pub mod epoch_info { | |||
| let block_producers_sampler = stake_weights(&block_producers_settlement); | |||
| let chunk_producers_sampler = | |||
| chunk_producers_settlement.iter().map(|vs| stake_weights(vs)).collect(); | |||
| #[cfg(feature = "protocol_feature_chunk_validation")] | |||
There was a problem hiding this comment.
We should use checked_feature!("protocol_feature_chunk_validation", ChunkValidation, protocol_version) as the condition. This checks not only the feature flag, but that the protocol version is new enough.
There was a problem hiding this comment.
Addressed in a2415c1.
| if checked_feature!( | ||
| "protocol_feature_chunk_validation", | ||
| ChunkValidation, | ||
| protocol_version | ||
| ) { | ||
| // This block is entered only if feature `protocol_feature_chunk_validation` is | ||
| // enabled. In that case `validator_mandates` is a parameter of the function and | ||
| // the variable shadowing below is not included. Still, the following | ||
| // declaration of `validator_mandates` is needed to satisfy the compiler. | ||
| #[cfg(not(feature = "protocol_feature_chunk_validation"))] |
There was a problem hiding this comment.
Assuming the path returning EpochInfo::V2 is still needed, I couldn't see a better way than nesting ifs and feature checking here.
There was a problem hiding this comment.
Yeah this is expected. And yes you're right, all prior code paths are still needed.
| if checked_feature!( | ||
| "protocol_feature_chunk_validation", | ||
| ChunkValidation, | ||
| protocol_version | ||
| ) { | ||
| // This block is entered only if feature `protocol_feature_chunk_validation` is | ||
| // enabled. In that case `validator_mandates` is a parameter of the function and | ||
| // the variable shadowing below is not included. Still, the following | ||
| // declaration of `validator_mandates` is needed to satisfy the compiler. | ||
| #[cfg(not(feature = "protocol_feature_chunk_validation"))] |
There was a problem hiding this comment.
Yeah this is expected. And yes you're right, all prior code paths are still needed.
Implements chunk validator assignment as described in
The term seat
In
nearcoreit is already used:seat_priceis the minimum stake required to become a validator.NumSeatsis the number of seats available for block producers.This might lead to conflicts and confusion with the concept of seat to be introduced for chunk validator assignment. To avoid that, this PR uses the term mandate for now. Accordingly the stake of chunk validators is splitt into mandates which are randomly shuffled and assigned to shards.
I’m happy to rename mandate to anything else, though if possible I would try to avoid conflicts with the existing usage of seat.
Overview
EpochInfoV4which contains the epoch’sValidatorMandates.EpochInfo::sample_chunk_validatorswhich allows sampling for a given height.core::primitives::validator_mandatesencapsulates splitting validator stake into mandates, shuffling them, and assigning them to shards.Follow-up concerns
As discussed offline (ref), the following are separate concerns:
stake_per_mandateandmin_mandates_per_shard.Hence there are some open
TODOs in the diff, they are marked with #10014.