Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write a spec for GC #61

Closed
ailisp opened this issue May 1, 2020 · 6 comments
Closed

Write a spec for GC #61

ailisp opened this issue May 1, 2020 · 6 comments
Assignees
Labels
WG-protocol Protocol Standards Work Group should be accountable

Comments

@ailisp
Copy link
Member

ailisp commented May 1, 2020

The corresponding work item: near/nearcore#2596

@ailisp ailisp added the WG-protocol Protocol Standards Work Group should be accountable label May 1, 2020
@ailisp ailisp self-assigned this May 1, 2020
@bowenwang1996
Copy link
Collaborator

Why does GC need a spec? It is strictly not part of the protocol.

@ailisp
Copy link
Member Author

ailisp commented May 6, 2020

@bowenwang1996 i talked to @SkidanovAlex he think we still need specs for our implementation specific feature like GC but not as part of "protocol spec"

@bowenwang1996
Copy link
Collaborator

@ailisp then it should not be in this repo. We can discuss where this should go (can potentially have it in nearcore wiki or some nearcore specific documentation).

@mfornet
Copy link
Member

mfornet commented May 7, 2020

While it is not strictly mandatory implementing GC (or implementing in the way we are doing it) having a spec for GC is important for several reasons from my POV.

  • Running a node without GC will require higher harder requirements (so potentially a node is not able to run without it by default).
  • GC Spec is responsible to explain what parts can be pruned away.

I'm not familiar enough with GC, but it can be the case that:

  • the design of chain is adapted to take into account our GC implementation, so this spec is a very good place to explain how to implement performant GC.

I agree, that we should tag this spec as not mandatory/recommended, but still think this is a great place to keep it.

@bowenwang1996
Copy link
Collaborator

design of chain is adapted to take into account our GC implementation

This is not the case and should not be the case. GC design should be specific to the implementation of the client. As along as chain is designed in a way to tolerate potential gc, it is fine.

this is a great place to keep it

As I said, we should only put the spec of the protocol here. Unless we somehow think GC is part of the protocol (which I disagree with), we should not put gc related stuff here.

@ailisp
Copy link
Member Author

ailisp commented May 26, 2020

Wrote a private one in notion for now

@ailisp ailisp closed this as completed May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WG-protocol Protocol Standards Work Group should be accountable
Projects
None yet
Development

No branches or pull requests

3 participants