-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write a spec for GC #61
Comments
Why does GC need a spec? It is strictly not part of the protocol. |
@bowenwang1996 i talked to @SkidanovAlex he think we still need specs for our implementation specific feature like GC but not as part of "protocol spec" |
@ailisp then it should not be in this repo. We can discuss where this should go (can potentially have it in nearcore wiki or some nearcore specific documentation). |
While it is not strictly mandatory implementing GC (or implementing in the way we are doing it) having a spec for GC is important for several reasons from my POV.
I'm not familiar enough with GC, but it can be the case that:
I agree, that we should tag this spec as not mandatory/recommended, but still think this is a great place to keep it. |
This is not the case and should not be the case. GC design should be specific to the implementation of the client. As along as chain is designed in a way to tolerate potential gc, it is fine.
As I said, we should only put the spec of the protocol here. Unless we somehow think GC is part of the protocol (which I disagree with), we should not put gc related stuff here. |
Wrote a private one in notion for now |
The corresponding work item: near/nearcore#2596
The text was updated successfully, but these errors were encountered: