refactor: Aggregate worker metrics in background #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morgsmccauley
commented
Nov 1, 2023
|
|
||
| export default class StreamHandler { | ||
| private readonly worker?: Worker; | ||
| private readonly worker: Worker; |
There was a problem hiding this comment.
This will always be defined, otherwise the constructor will throw
darunrs
approved these changes
Nov 1, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we would need to manually send the metric data to the main thread, then write the metric there. This PR updates worker metrics so it is done seamlessly in the background, metrics can be written as normal regardless of whether in the main thread or not. This is achieved by sending all metrics collected within a worker to the main thread, and then aggregating them there.