Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

541 update the frontend to dis allow use of this filter #583

Merged

Conversation

Kevin101Zhang
Copy link
Contributor

@Kevin101Zhang Kevin101Zhang commented Feb 26, 2024

Looks like the middleware file was pushed on a dev branch and was ignored when testing for CORS options.
Fix: removed- frontend/src/pages/middleware.js
out CORS is created from nextjs looking at next.config.js which is a sibling of package.json

@Kevin101Zhang Kevin101Zhang requested a review from a team as a code owner February 26, 2024 21:58
@Kevin101Zhang Kevin101Zhang force-pushed the 541-update-the-frontend-to-dis-allow-use-of-this-filter branch from 44b7f0d to cb07bd5 Compare February 26, 2024 23:14
@darunrs
Copy link
Collaborator

darunrs commented Feb 26, 2024

Still not sure why so many commits are still showing up but the squash will get rid of them anyway I guess. Just make sure to checkout off main after pulling when this is merged, to get rid of whatever those commits are.

@Kevin101Zhang Kevin101Zhang merged commit 625b4cb into main Feb 26, 2024
@Kevin101Zhang Kevin101Zhang deleted the 541-update-the-frontend-to-dis-allow-use-of-this-filter branch February 26, 2024 23:36
@darunrs darunrs mentioned this pull request Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants