-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Update HERE Wallet and add topLevelInjected #1077
feat: Update HERE Wallet and add topLevelInjected #1077
Conversation
@AZbang can you help me understand why |
@ewiner Added a description to the metadata parameters |
@ewiner The video in the PR description shows that when opening a site inside an iframe, here-wallet transmits wallet data inside the site through here-wallet/core using an iframe postMessage. However, in order for the wallet to be immediately initialized inside wallet-selector, it is necessary to call initialization through modal-ui. The only way to tell modal-ui whether to signIn immediately is to pass a special parameter to metadata.
|
So the idea is for an injected wallet to force automatic sign-in, so the user doesn't have to click "Connect Wallet" or "Sign In". I'm new to this codebase, but two questions/comments come to mind:
|
|
This PR will be eligible for merge into main after review by community and Pagoda. Thanks! |
@kujtimprenkuSQA is no longer working on this project. If he wants to volunteer his personal time, it would be welcome, however I don't want any SQA folks added as reviewers. I am trying to encourage the community to review this PR. This is still in progress. Thanks! |
Agree with @ewiner. This PR change is tailored for specific problem that Here wallet is experiencing. Not disagree with the direction of the PR, but ideally this should have been proposed on NEP and approved by the community and users. Or at least, I would prefer to get reviewed/feedback by other builder group community, specially around the maintainers of other injected wallets. |
The idea of wallet-selector is to help projects have access to users. Now we have a Telegram Wallet where large group of all active users are on NEAR. At the same time, no project on NEAR can provide services to such users. By delaying, we are isolating the ecosystem from users. I believe that taking into account the real state of affairs in the ecosystem, this PR is for the public good and should be implemented in the near future. |
@ewiner @trechriron @hcho112 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
thank you @Patrick1904 |
It was necessary to add the ability to associate an application inside an iframe with a parent window and allow seamless initialization and method calls. This will help integrate applications inside wallets. For example Telegram HERE Wallet:
RPReplay_Final1707785907.mp4
topLevelInjected
method is needed because wallet-selector is designed in such a way that only modal-ui knows about the contract that the application uses.