feat: add WELLDONE extension wallet #477

Yoon-Suji · 2022-09-30T04:23:36Z

Description

WELLDONE extension wallet is multi-chain wallet that support NEAR protocol. You can read more information in here.

Checklist:

I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings

Type of change.

kujtimprenkuSQA · 2022-09-30T11:50:31Z

Hey, @Yoon-Suji thank you for submitting this PR.

Could you please add a (docs) Readme.md file to the package like it's done with other packages (wallets) in this repo?

Before reviewing the code I tried to install and test out the functionality of this wallet/extension but for some reason, I am unable to create a new wallet with this extension it always gets stuck in this view:

Yoon-Suji · 2022-10-04T01:29:13Z

@kujtimprenkuSQA Hi, I'm sorry for late response😂
I tried it again and it works well. Can you please check the chrome version? And also I added docs in packages.

kujtimprenkuSQA · 2022-10-04T08:39:48Z

This is the chrome version I am using on this machine, I think it's the latest version:

Version 106.0.5249.91 (Official Build) (64-bit)

The Welldone wallet is still not working for me, will ask other team members to have a look at it too.

amirsaran3 · 2022-10-04T10:28:38Z

Hey @Yoon-Suji. I was able to successfully create an account using the WELLDONE extension. I built your branch to test the functionality and I am seeing a couple of bugs:

When refreshing page I get logged out (session is cleared).
signAndSendTransaction and signAndSendTransactions functions are not working for me. I am getting this error which is not letting me to sign transactions:

amirsaran3 · 2022-10-04T10:51:10Z

packages/welldone-wallet/src/lib/welldone.ts

+      };
+    },
+
+    async signAndSendTransaction({ signerId, receiverId, actions }) {


You should consider using the signTransactions function in packages\wallet-utils\src\lib\sign-transactions.ts when signing to avoid using these "helper function" like _validateAccessKey, convertTransaction and convertActions. All of the above functions are used in signTransactions. This way we avoid duplicating code.

You will have to provide a signer: Signer object to the signTransactions function. You can check out the nightly package and see how they have done it.

We implemented a method of signing before sending a transaction on its own inside the wallet. So we use it instead of using the signTransactions function.

Hey, I changed the signAndSendTransaction method to using signTransactions function. But the signAndSendTransactions method still uses the dapp:sendTransaction method (the wallet signs and sends transactions) because we do not currently support signing multiple transactions. This code will change after the wallet has been updated.

Thanks, we're going to have a look at.

Hi @Yoon-Suji , I'm unable to create or import wallet as well. Getting stuck on "Create a wallet" screen

Tried it on two machines with Chrome Versions 106.0.5249.119 (Official Build) (64-bit) and 106.0.5249.103 (Official Build) (64-bit). The same goes for Brave browser so you might want to investigate.

Small thing I've noticed with password rule text... It says "write more than 8 letters" instead of "write 8 or more characters" if you want to change that.

Hi @DamirSQA , We are trying to reproduce the exceptional situation where the error occurs.
So I would really appreciate it if you could send me the console log by right-clicking on the Create a Wallet screen and clicking the inspect button.
Thanks for reporting the issue.

You're welcome, here is the log

Thanks, @DamirSQA We updated our wallet in chrome web store.
Could you turn off all the other wallet extensions and try again?
If it works well, I would appreciate it if you could tell me the type of extension you are using.
If it still doesn't work, Could you send me the console log one more time, please?

Removing extensions didn't make a difference. On some devices it does work, on the others does not.

packages/welldone-wallet/src/lib/welldone.ts

AmmarHumackicSQA · 2022-10-04T13:08:15Z

Hi @Yoon-Suji , thanks for submitting the PR. As a reminder, the security statement needs to be shown either on the GitHub profile/repo or the website. You can check it here again. Thanks!

Yoon-Suji · 2022-10-06T01:29:35Z

Hi @AmmarHumackicSQA
We added the security statement to our GitHub organization profile! you can check it here

Yoon-Suji · 2022-10-06T06:04:57Z

Hi @amirsaran3
First of all, thanks for letting us know about the bug.
There was an issue with the RPC node we use, which is why the signAndSendTransaction and signAndSendTransactions methods failed. We fixed it and uploaded the updated wallet to the chrome webstore. Could you please delete the current version of WELLDONE extension wallet and re-download it?
And I fixed some of the code by reflecting on your comments. Please check it!

amirsaran3 · 2022-10-06T09:23:34Z

Hi @amirsaran3 First of all, thanks for letting us know about the bug. There was an issue with the RPC node we use, which is why the signAndSendTransaction and signAndSendTransactions methods failed. We fixed it and uploaded the updated wallet to the chrome webstore. Could you please delete the current version of WELLDONE extension wallet and re-download it? And I fixed some of the code by reflecting on your comments. Please check it!

Hey @Yoon-Suji. I tested your new version and signing works. However wallets should have a function that allows us to just sign the transaction and return the signature. Is it possible to add near:signTransaction and near:signTransactions request methods?

Yoon-Suji · 2022-10-11T07:09:42Z

Hi @amirsaran3 First of all, thanks for letting us know about the bug. There was an issue with the RPC node we use, which is why the signAndSendTransaction and signAndSendTransactions methods failed. We fixed it and uploaded the updated wallet to the chrome webstore. Could you please delete the current version of WELLDONE extension wallet and re-download it? And I fixed some of the code by reflecting on your comments. Please check it!

Hey @Yoon-Suji. I tested your new version and signing works. However wallets should have a function that allows us to just sign the transaction and return the signature. Is it possible to add near:signTransaction and near:signTransactions request methods?

Hey @amirsaran3. Welldone wallet has the dapp:sign method, that allows you to sign messages and transactions. I also added a signer:Signer object as you suggested and used it to verifyOwner function, please check!

amirsaran3 · 2022-10-11T08:49:58Z

@Yoon-Suji After latest changes I get this error when trying to sign message:

Also there is no info about the dapp:sign method in your docs (https://docs.welldonestudio.io/wallet/developer-guide/provider-api/method).

Yoon-Suji · 2022-10-12T05:02:01Z

@amirsaran3
This is the issue that the old query was deprecated in view_access_key RPC api during the testnet upgrade process. NEAR replied that it would revert for users who use old query, but we modified the wallet in a way that does not use old query according to NEAR's initial intention. But the testnet is currently down, so if it operates again, the modifications will be reflected after the test.

And also I'll add a description of the dapp:sign method to our docs. Could you leave the same comment on our Github issue? We want the docs github issue activated :)

Yoon-Suji · 2022-10-14T03:02:44Z

Hi @amirsaran3 , we checked again and it seems that all works well with WELLDONE version 0.0.25 (latest version updated in the store) Could you try again? And we updated our docs too!

Yoon-Suji · 2022-10-18T06:59:40Z

hey, we implemented the signTransaction function.

If the signMessage method in Signer takes arguments as a transaction, it signs Transaction, if the method takes arguments as a message, it signs message. So I also changed signAndSendTransaction method to using signTransactions in packages\wallet-utils\src\lib\sign-transactions.ts

But we are not supported signing multiple transactions because currently the Welldone wallet was ready to send multiple transactions, but it is not ready to sign multiple transactions. So the signAndSendTransactions method still using dapp:sendTransaction method which is signing and sending transactions at once in the wallet. If required, we will include multiple transaction signing in the next wallet release.

packages/welldone-wallet/src/lib/injected-welldone.ts

daoauth and others added 12 commits September 27, 2022 13:30

add: welldone-wallet

6d76ace

bugfix

4a01bf4

fix: resolve receiverId error

c1e0426

fix: change provider to dapp(Universal provider)

3be6771

fix: dapp:chainChanged event

0d21363

feat: add verifyOwner

7891fc0

fix: welldone icon

41aa7d1

fix: delete keyType in verifyOwner

69d6e90

Merge branch 'main' of https://github.com/welldonestudio/wallet-selector

d13941f

docs: edit readme

347192b

Merge branch 'near:dev'

4d12b24

fix: fix eslint

12588d0

docs: add readme

d1b1738

amirsaran3 reviewed Oct 4, 2022

View reviewed changes

packages/welldone-wallet/src/lib/welldone.ts Outdated Show resolved Hide resolved

fix: login issue

72db878

Yoon-Suji added 2 commits October 11, 2022 15:33

feat: add Signer

fe56edb

Merge branch 'near:dev'

b2a9ff8

fix: fix signMessage method

84917fb

Yoon-Suji requested a review from amirsaran3 October 18, 2022 01:29

feat: add signTransaction

2165355

DamirSQA reviewed Oct 19, 2022

View reviewed changes

packages/welldone-wallet/src/lib/injected-welldone.ts Outdated Show resolved Hide resolved

fix: delete unnecessary export

109a308

DamirSQA approved these changes Oct 25, 2022

View reviewed changes

DamirSQA merged commit 4315b03 into near:dev Oct 25, 2022

kujtimprenkuSQA mentioned this pull request Nov 7, 2022

v7.2.0 Release (dev -> main) #548

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add WELLDONE extension wallet #477

feat: add WELLDONE extension wallet #477

Yoon-Suji commented Sep 30, 2022

kujtimprenkuSQA commented Sep 30, 2022

Yoon-Suji commented Oct 4, 2022

kujtimprenkuSQA commented Oct 4, 2022

amirsaran3 commented Oct 4, 2022

amirsaran3 Oct 4, 2022

Yoon-Suji Oct 5, 2022 •

edited

Yoon-Suji Oct 18, 2022

DamirSQA Oct 18, 2022

DamirSQA Oct 19, 2022

Yoon-Suji Oct 20, 2022

DamirSQA Oct 20, 2022

Yoon-Suji Oct 21, 2022 •

edited

DamirSQA Oct 21, 2022

AmmarHumackicSQA commented Oct 4, 2022

Yoon-Suji commented Oct 6, 2022

Yoon-Suji commented Oct 6, 2022

amirsaran3 commented Oct 6, 2022

Yoon-Suji commented Oct 11, 2022 •

edited

amirsaran3 commented Oct 11, 2022

Yoon-Suji commented Oct 12, 2022

Yoon-Suji commented Oct 14, 2022

Yoon-Suji commented Oct 18, 2022

feat: add WELLDONE extension wallet #477

feat: add WELLDONE extension wallet #477

Conversation

Yoon-Suji commented Sep 30, 2022

Description

Checklist:

Type of change.

kujtimprenkuSQA commented Sep 30, 2022

Yoon-Suji commented Oct 4, 2022

kujtimprenkuSQA commented Oct 4, 2022

amirsaran3 commented Oct 4, 2022

amirsaran3 Oct 4, 2022

Choose a reason for hiding this comment

Yoon-Suji Oct 5, 2022 • edited

Choose a reason for hiding this comment

Yoon-Suji Oct 18, 2022

Choose a reason for hiding this comment

DamirSQA Oct 18, 2022

Choose a reason for hiding this comment

DamirSQA Oct 19, 2022

Choose a reason for hiding this comment

Yoon-Suji Oct 20, 2022

Choose a reason for hiding this comment

DamirSQA Oct 20, 2022

Choose a reason for hiding this comment

Yoon-Suji Oct 21, 2022 • edited

Choose a reason for hiding this comment

DamirSQA Oct 21, 2022

Choose a reason for hiding this comment

AmmarHumackicSQA commented Oct 4, 2022

Yoon-Suji commented Oct 6, 2022

Yoon-Suji commented Oct 6, 2022

amirsaran3 commented Oct 6, 2022

Yoon-Suji commented Oct 11, 2022 • edited

amirsaran3 commented Oct 11, 2022

Yoon-Suji commented Oct 12, 2022

Yoon-Suji commented Oct 14, 2022

Yoon-Suji commented Oct 18, 2022

Yoon-Suji Oct 5, 2022 •

edited

Yoon-Suji Oct 21, 2022 •

edited

Yoon-Suji commented Oct 11, 2022 •

edited