Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle external linked issues #179

Closed
simoneb opened this issue Nov 18, 2022 · 1 comment · Fixed by #181
Closed

Handle external linked issues #179

simoneb opened this issue Nov 18, 2022 · 1 comment · Fixed by #181
Assignees

Comments

@simoneb
Copy link
Contributor

simoneb commented Nov 18, 2022

When the action does a release it by default tries to comment on the linked issues of each PR included in the release, mentioning in which release the issue was addressed.

We came across a case whereby the linked issue was in a different repo, which failed the action. See here.

The action needs to handle this more correctly and post the comment on the issue in a "best effort" way. It should still try, but it shouldn't fail the execution if it cannot comment. Also note that I'm not even sure this case should have failed, it's just that the action tried to post the comment on an issue that doesn't exist because it was searching for that issue in the same repo, whereas it was an external repo.

@github-actions
Copy link

🎉 This issue has been resolved in version 4.0.2 🎉

The release is available on:

Your optic bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants