chore: bump aws-sdk from v2 to v3 #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simoneb
approved these changes
Jun 10, 2024
There was a problem hiding this comment.
The code changes LGTM although GitHub's security features are preventing tests from running, because variables used by the CI workflow are not being provided due to your changes living in a fork. I will approve and merge the PR, and we'll see if it works when merged in master. If it doesn't, we can do another iteration.
|
@fedefrusc tests were mostly fine, but CI is failing due to missing coverage. You probably removed a test case where we were testing for a binary being returned by the API. |
|
@simoneb yes I had to change the test because of the new sdk version. I didn't notice the failed covarege. if you agree I'll do another PR, fixing the coverage. |
|
Yes please, go ahead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #367