Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release Workflow #175

Merged
merged 3 commits into from
Apr 19, 2022
Merged

Release Workflow #175

merged 3 commits into from
Apr 19, 2022

Conversation

rp4rk
Copy link
Contributor

@rp4rk rp4rk commented Apr 19, 2022

Closes #174

Adds the release workflow to the repository.

simoneb
simoneb requested changes Apr 19, 2022
View reviewed changes
Copy link
Member

@simoneb simoneb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a package, so the workflow will have to be different. Sorry for misleading you by mentioning the template repo, you should probably inspire from a repo containing a package, e.g. fast-jwt

@rp4rk rp4rk requested a review from simoneb April 19, 2022 12:49
simoneb
simoneb reviewed Apr 19, 2022
View reviewed changes
Copy link
Member

@simoneb simoneb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also include the semver input as a choice? You may want to update fast-jwt to reflect this. This workflow is an earlier version but not all repos have been updated it seems.

@rp4rk rp4rk requested a review from simoneb April 19, 2022 13:37
@simoneb
Copy link
Member

simoneb commented Apr 19, 2022

You can merge but hold back from releasing as there is additional work to be done first

@rp4rk rp4rk merged commit 463b6b8 into master Apr 19, 2022
@rp4rk rp4rk deleted the task/add-release-workflow branch April 19, 2022 13:51
@optic-release-automation optic-release-automation bot mentioned this pull request Apr 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simoneb simoneb simoneb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add release automation
2 participants
@rp4rk @simoneb