feat: rethrow original error

[MilosRasic]

Just suggesting this change because what's thrown right now isn't very useful for figuring out what went wrong:

But if we just re-throw the original error:

Now I know someone actually has a GCP project called "baby" but Secret Manager isn't enabled for it 🙂

Tests are passing because they assert only that an error is thrown.

[github-actions]

No linked issues found. Please add the corresponding issues in the pull request description.
Use GitHub automation to close the issue when a PR is merged

[simoneb]

Well I guess in this case there's no point in catching the error in the first place then

[MilosRasic]

Well I guess in this case there's no point in catching the error in the first place then

True. Removed try..catch. Feels good 🙂

[simoneb]

You may have to update some tests, CI is red

[MilosRasic]

Looks like it's not even reaching the tests. Fails to authenticate with GCP

PRs triggered from forks don't get the secrets injected. If you don't mind potentially exposing the secrets, pull_request_target trigger instead of pull_request should work.

Otherwise, there are more complex options: https://securitylab.github.com/research/github-actions-preventing-pwn-requests/

[simoneb]

Ah no you're right, I assumed the issue was different