chore: bump tap to 15.0.2 #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simoneb
requested changes
Apr 7, 2021
There was a problem hiding this comment.
Overall LGTM, let's consider this both for this PR and for further ones:
- you can push commits to the Dependabot PRs, you don't have to create new ones. Make sure to request a review in order to notify me to review them or I won't know
- this codebase contained mistakes but there is more to this in the upgrade. Namely, check out the build logs and please make changes to address the deprecations, which will be logged as warnings while the tests run. One such deprecation you'll find in this codebase is:
(node:1997) DeprecationWarning: sameStrict() is deprecated, use strictSame() instead
For this, Matteo's script could be useful.
simoneb
approved these changes
Apr 7, 2021
This was referenced May 3, 2021
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.