Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs update - JWKS example #51

Merged
merged 3 commits into from
Apr 26, 2021
Merged

Docs update - JWKS example #51

merged 3 commits into from
Apr 26, 2021

Conversation

sameer-coder
Copy link
Contributor

JWKS example updated to use key as a function

simoneb
simoneb reviewed Apr 26, 2021
View reviewed changes
Copy link
Member

@simoneb simoneb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The example in the docs comes from an example that we have in integration tests. Can you update that one too?

@sameer-coder
Copy link
Contributor Author

Sure. I will take care of that too

simoneb
simoneb approved these changes Apr 26, 2021
View reviewed changes
Copy link
Member

@simoneb simoneb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sameer-coder sameer-coder merged commit 4c60102 into main Apr 26, 2021
@sameer-coder sameer-coder deleted the docs-update-jwks-example branch April 26, 2021 10:32
This was referenced May 3, 2021
Closed
Closed
Closed
@optic-release-automation optic-release-automation bot mentioned this pull request Jan 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simoneb simoneb simoneb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sameer-coder @simoneb