This repository has been archived by the owner on Jan 29, 2024. It is now read-only.
feat: filter out dependabot notifications #599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brainrepo
force-pushed
the
feat/587-filter-out-dependabot-notifications
branch
from
31a98d6
to
3df3ac1
Compare
simoneb
reviewed
Apr 24, 2023
src/slackbot.js
Outdated
Comment on lines
39
to
41
| excludedAuthors.includes(node.content?.author?.login) || | ||
| excludedAuthors.includes(node.content?.content?.author?.login) || | ||
| excludedAuthors.includes(node.content?.creator?.login) |
There was a problem hiding this comment.
why are we checking in so many places? surely the dependabot PRs will carry this information consistently in a single place, don't they?
simoneb
reviewed
Apr 25, 2023
test/routes/webhook.test.js
Outdated
| }, | ||
| }) | ||
|
|
||
| t.test('item created by dependabot', async t => { |
There was a problem hiding this comment.
can we improve these tests' descriptions by including what the outcome of the test is? e.g. "doesn't do anything if it's dependabot PR".
test/routes/webhook.test.js
Outdated
| 'X-Hub-Signature-256': signature, | ||
| }, | ||
| }) | ||
| t.equal(slackStub.callCount, 0) |
There was a problem hiding this comment.
minor but can we use sinon to make these assertions? e.g. sinon.assertNotCalled(slackStub)
There was a problem hiding this comment.
The Sinon assertion doesn't increment the tap report assertion counter.
I reverted it, but I am happy to restore it.
src/graphql.js
Outdated
| @@ -106,6 +106,10 @@ export const getActivityById = async ({ graphqlClient, id }) => { | |||
| number | |||
| title | |||
| url | |||
| author { | |||
| url | |||
simoneb
approved these changes
Apr 25, 2023
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #587