feat: improve test and isqual function

nearform · Aug 17, 2023 · a609bd2 · a609bd2
1 parent b4f5115
commit a609bd2
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/packages/graphql-hooks/src/utils.ts b/packages/graphql-hooks/src/utils.ts
@@ -30,10 +30,9 @@ export function isEqualFirstLevel<T extends Record<string, any>>(
     return false
   }
 
-  for (const key of keys1) {
-    if (!keys2.includes(key) || obj1[key] !== obj2[key]) {
-      return false
-    }
+  for (let i = 0; i < keys1.length; i++) {
+    const key = keys2[i]
+    if (!(key in obj2) || !Object.is(obj1[key], obj2[key])) return false
   }
 
   return true

diff --git a/packages/graphql-hooks/test-jsdom/unit/utils.test.ts b/packages/graphql-hooks/test-jsdom/unit/utils.test.ts
@@ -54,6 +54,10 @@ describe('GraphQLClient utils', () => {
       expect(isEqualFirstLevel({ a: 1, b: 2 }, { a: 1, b: 2 })).toBe(true)
     })
 
+    it('returns true for two objects with the same keys and values but different keys order', () => {
+      expect(isEqualFirstLevel({ a: 1, b: 2 }, { b: 2, a: 1 })).toBe(true)
+    })
+
     it('returns true with the same object', () => {
       const obj = { a: 1, b: 2 }
       expect(isEqualFirstLevel(obj, obj)).toBe(true)