-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replaced graphql-request + refactored error handling #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmullan91
commented
Feb 14, 2019
bmullan91
commented
Feb 14, 2019
bmullan91
commented
Feb 14, 2019
bmullan91
force-pushed
the
replace_graphql_request
branch
from
February 14, 2019 12:17
a049094
to
3e48b55
Compare
bmullan91
changed the title
[WIP] Replaced graphql-request + refactored error handling
Replaced graphql-request + refactored error handling
Feb 14, 2019
jackdclark
reviewed
Feb 14, 2019
This reverts commit bf88983.
jackdclark
previously approved these changes
Feb 15, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome 👍
README.md
Outdated
endpoint: '/graphql' | ||
const client = new GraphQLClient({ | ||
url: '/graphql', | ||
fetch // pass your preferred polyfill here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe state that it's optional?
This was referenced Feb 15, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1, #2
createClient
->GraphQLClient
classendpoint
->url
fetch
: optional function to specify the fetch implementation | defaults to global fetchAdditions
new GraphQLClient(config)
:logErrors
: Boolean | default trueonError
: Function - custom error handler will receive ({ result, operation }) as the argumentresult
object from all hooks:fetchError
: if an error occurred during the fetch call it will be available herehttpError
: if a http error occurred it will be available heregraphQLErrors
: The array of GraphQL errors from the server responseerror
: Boolean set to true if any of the above errors have been setcacheHit
: Boolean set to true if the result came from the cache, useful for debuggingoperationName
can now be set:useQuery(query, { variables: {...}, operationName: 'MyOperation' })
useMutation(mutation, { variables: {...}, operationName: 'MyOperation' })
const [myMutation] = useMutation(mutation); myMutation({ variables: {}, operationName: 'MyOperation' })