Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use POSIX compatible comparison operator #89

Merged
merged 1 commit into from
Mar 3, 2023
Merged

Conversation

blucas
Copy link
Contributor

@blucas blucas commented Mar 3, 2023

What does this PR do?

Fixes issue on MacOS terminals (the default is zsh) when attempting to source the .envrc file.

The error is being generated for the syntax of the if statement

if [ "${KKA_AOA_EXCLUDE_ISTIO}" == "true" ]; then
  export KKA_AOA_EXCLUDE_KNATIVE="true"
else

for compatibility reasons, we should use = instead of ==

Related issues

Closes #88

Checklist before merging

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have checked the contributing document.
  • I have checked the existing Pull Requests to see whether someone else has raised a similar idea or question.
  • I have added tests that prove my fix is effective or that my feature works.

@blucas blucas requested a review from LucaLanziani March 3, 2023 13:09
@LucaLanziani LucaLanziani merged commit 231c3cc into main Mar 3, 2023
@LucaLanziani LucaLanziani deleted the fix-envrc branch March 3, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[LOCAL] - Sourcing .envrc fails on default MacOS X installation
2 participants