Demo page improvements and restyling #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Paolo! (nice name XD) |
|
Yeah of course! I'll do it this evening ;) |
|
Just to be sure, I added this heading to the demo page: Do you prefer this style or the one that there is right now? |
|
@paolo-cargnin What about having that gradient in lieu of the current pink background in the hero and use regular text? |
|
Ok done. Most of the usability features were already done by you. I list here the super small things that I have done:
|
ShogunPanda
approved these changes
Aug 8, 2022
micheleriva
approved these changes
Aug 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I read the tweet of Michele, and I tried to improve the demo page as I could without having any specification about the needs.
I aligned better the form elements and changed the header of the page (imho this style is cleaner and more modern, maybe we could adopt it even in the homepage?).
I also added autofocus on the search input.
Of course if it is not as you guys were thinking it, I can improve it.
The main part now that should be improved is the search results, but about this... Can I suggest to use a better structured database? The categories in this example are not easy to display and organize since they are not always the same. Maybe using some more "mainstream" data could be nice (I was thinking movie quotes) ? Dunno.
Let me know!