Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update node-test-parser to the latest release and fix error parsing #105

Merged
merged 2 commits into from
Sep 28, 2023

Conversation

msebastianb
Copy link
Contributor

@msebastianb msebastianb commented Sep 27, 2023

With the latests updates of the node test runner there are some inconsistencies in reported data:

Solution:

  • Update node-test-parser
  • Fix the parsing logic of the new error object on failing tests

Resolve #106

@msebastianb msebastianb marked this pull request as ready for review September 28, 2023 07:21
@simoneb
Copy link
Member

simoneb commented Sep 28, 2023

Can you please post a screenshot which shows before and after the fix?

@msebastianb
Copy link
Contributor Author

Thanks @simoneb for the review, before this fix in case of failing tests there's nothing shown. After the fix the reported result is similar to this one:

Screenshot 2023-09-28 at 10 40 31

Looking at it probably something more for the reported stack of every failing test could be done, as you can see there is a repetition of the expected result inside the stack box, this happens due to some changes in the error message and probably using the stack parsing library in a different way could fix this. I'll take some time to give it a try.

@simoneb
Copy link
Member

simoneb commented Sep 28, 2023

approved, merge away

@msebastianb msebastianb merged commit 68457b7 into master Sep 28, 2023
4 of 5 checks passed
@msebastianb msebastianb deleted the update_parser branch September 28, 2023 09:03
@github-actions github-actions bot mentioned this pull request Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Report is not created in case of failing tests
2 participants