Skip to content
This repository has been archived by the owner on Mar 11, 2019. It is now read-only.

Updated development-workflow exercise. Added target to build commands for sudc in the others #39

Open
wants to merge 3 commits into
base: v0.14-dev
Choose a base branch
from

Conversation

mcollina
Copy link
Contributor

@darragh-hayes please review and merge if it works for you. Make any updates you think this need.

cc @pelger.

@@ -38,7 +38,7 @@ git commit -m "Added buggy alert"
Build the container and deploy the latest revision:
```bash
nscale system compile sudc development
nscale container build sudc web
nscale container build sudc web development
nscale revision deploy sudc latest development
```

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the command be dev over development here? it seems the docs have dev in some places, development in others`. Unless there is a reason we should perhaps stick to one convention for docs? @darragh-hayes can you check this? @mcollina can you confirm?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A target can be abbreviated, but ok for consistency!
Il giorno gio 26 feb 2015 alle 12:15 Dean McDonnell <
notifications@github.com> ha scritto:

In 5-update-&-rollback.md
#39 (comment)
:

@@ -38,7 +38,7 @@ git commit -m "Added buggy alert"
Build the container and deploy the latest revision:

 nscale system compile sudc development
-nscale container build sudc web
+nscale container build sudc web development
 nscale revision deploy sudc latest development

Should the command be dev over development here? it seems the docs have
dev in some places, development in others. Unless there is a reason we
should perhaps stick to one convention for docs? @darragh-hayes
https://github.com/darragh-hayes can you check this? @mcollina
https://github.com/mcollina can you confirm?


Reply to this email directly or view it on GitHub
https://github.com/nearform/nscale-workshop/pull/39/files#r25419658.

@darahayes
Copy link

@mcdonnelldean Wherever it says "dev" is should be "development". The nscale commands can be shortened and it can recognise shortened system names. However special arguments such as "latest" (as a revision), as well as target environments must be specified in full. Tested again just to confirm

@mcdonnelldean
Copy link

Good to know, as @mcollina confirmed, can we change them all to the full one for consistency in docs and we can add a note in the commands doc (when it's written) to explain when short names can and cannot be used? Otherwise it's confusing :D

@mcollina
Copy link
Contributor Author

The target should be abbreviae everywhere, open bugs in kernel when you
find this kind of stuff and I will get it fixed.
Il giorno gio 26 feb 2015 alle 12:22 Dean McDonnell <
notifications@github.com> ha scritto:

Good to know, as @mcollina https://github.com/mcollina confirmed, can
we change them all to the full one for consistency in docs and we can add a
note in the commands doc (when it's written) to explain when short names
can and cannot be used? Otherwise it's confusing :D


Reply to this email directly or view it on GitHub
#39 (comment)
.

@mcdonnelldean
Copy link

@mcollina Good good, I thought that was strange alright! @darragh-hayes Just so your aware here, go short, report the bugs. Best to have docs right rather than hiding bugs with them

@darahayes
Copy link

@mcdonnelldean @mcollina I have updated the commands across the board to suit the changes. We do support abbreviation of targets in build commands now but I have written them in full. I am a purist that way!

@mcdonnelldean
Copy link

@darragh-hayes good job although we both know that @mcollina is going to ask you to shorten them in the docs right... :D

@mcollina
Copy link
Contributor Author

ahhaha yes. But at some point I added some notes that stuff can be shortened up anyway. Is it still true?

@mcdonnelldean
Copy link

You did and it is.... just waiting for @darragh-hayes to realise his terrible, terrible, mistake 😸

@darahayes
Copy link

@mcollina in one of the very first guides you did! This is why I'm keeping them full length.

@mcollina
Copy link
Contributor Author

mcollina commented Mar 2, 2015

@darragh-hayes is this still needed?

@darahayes
Copy link

@mcollina I think this is completely down to one's opinion. The only difference between this and my PR is the use of process containers - which I've had a few problems with. Personally I think this one isn't needed for the moment.

@mcollina
Copy link
Contributor Author

mcollina commented Mar 2, 2015

@darragh-hayes can you please report the problems you had? Ok also for a quick skype call on the matter.

Also removed unnecessary information about git detached HEAD etc.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants