fix: use strict

packages/trail-fastify-plugin/README.md

@@ -15,14 +15,13 @@ npm install @nearform/trail-fastify-plugin
 ## Usage
 
 ```javascript
+const Fastify = require('fastify')
+
 const main = async function() {
-  import Fastify from 'fastify'
   const fastify = Fastify()
 
   fastify.register(require('@nearform/trail-fastify-plugin'))
 
-  await fastify.ready()
-
   await fastify.listen(3000, console.log)
 }
 

packages/trail-fastify-plugin/lib/api.js

@@ -1,3 +1,5 @@
+'use strict'
+
 const { get } = require('lodash')
 
 const addReference = function (spec) {

packages/trail-fastify-plugin/lib/index.js

@@ -1,3 +1,5 @@
+'use strict'
+
 const fp = require('fastify-plugin')
 const { TrailsManager } = require('@nearform/trail-core')
 const { get } = require('lodash')
@@ -72,9 +74,8 @@ async function trail (server, options) {
   server.decorate('trailCore', trailsManager)
   server.decorateReply('trailCore', trailsManager)
 
-  server.addHook('onClose', async (instance, done) => {
+  server.addHook('onClose', async instance => {
     await trailsManager.close()
-    done()
   })
 
   const ajv = new Ajv({ allErrors: true })

packages/trail-fastify-plugin/lib/routes/trails.js

@@ -1,11 +1,13 @@
+'use strict'
+
 const { notFound } = require('@hapi/boom')
 const S = require('fluent-schema')
 
 const { errorsSchemas } = require('../schemas/errors')
 const { spec, trailSchema } = require('../schemas/trails')
 const { addApiRoute, generateSpec } = require('../api')
 
-module.exports = async function (fastify, options, done) {
+module.exports = async function (fastify, options) {
   for (const path of ['/trails/openapi.json', '/trails/swagger.json']) {
     fastify.route({
       method: 'GET',
@@ -22,7 +24,7 @@ module.exports = async function (fastify, options, done) {
     async handler (request, reply) {
       const { from, to, who, what, subject, page, pageSize, sort } = request.query
       const results = await reply.trailCore.search({ from, to, who, what, subject, page, pageSize, sort })
-      reply.send(results)
+      return results
     },
     schema: {
       query: trailSchema.search,
@@ -46,7 +48,7 @@ module.exports = async function (fastify, options, done) {
     async handler (request, reply) {
       const { from, to, type, page, pageSize, desc } = request.query
       const results = await reply.trailCore.enumerate({ from, to, type, page, pageSize, desc })
-      reply.send(results)
+      return results
     },
     schema: {
       query: trailSchema.enumerate,
@@ -70,7 +72,8 @@ module.exports = async function (fastify, options, done) {
     async handler (request, reply) {
       const id = await reply.trailCore.insert(request.body)
       const trail = await reply.trailCore.get(id)
-      reply.code(201).send(trail)
+      reply.code(201)
+      return trail
     },
     schema: {
       headers: S.object()
@@ -99,7 +102,7 @@ module.exports = async function (fastify, options, done) {
 
       if (!trail) throw notFound(`Trail with id ${id} not found.`)
 
-      return reply.send(trail)
+      return trail
     },
     schema: {
       params: trailSchema.params,
@@ -127,7 +130,8 @@ module.exports = async function (fastify, options, done) {
       if (!updated) throw notFound(`Trail with id ${id} not found.`)
 
       const trail = await reply.trailCore.get(id)
-      reply.code(202).send(trail)
+      reply.code(202)
+      return trail
     },
     schema: {
       headers: S.object()
@@ -179,6 +183,4 @@ module.exports = async function (fastify, options, done) {
 
   // Add tagged routes to the swagger.json
   generateSpec(spec, 'trails')
-
-  done()
 }

packages/trail-fastify-plugin/lib/schemas/errors.js

@@ -1,3 +1,5 @@
+'use strict'
+
 const S = require('fluent-schema')
 
 const errorsMessages = {

packages/trail-fastify-plugin/lib/schemas/trails.js

@@ -1,3 +1,5 @@
+'use strict'
+
 const config = require('config')
 const S = require('fluent-schema')
 

packages/trail-fastify-server/lib/index.js

@@ -1,3 +1,5 @@
+'use strict'
+
 const S = require('fluent-schema')
 const fastify = require('fastify')
 const config = require('config')

packages/trail-fastify-server/lib/swagger.js

@@ -1,3 +1,5 @@
+'use strict'
+
 const { readFile } = require('fs').promises
 const { extname, join } = require('path')
 

packages/trail-fastify-server/start.js

@@ -1,3 +1,5 @@
+'use strict'
+
 // If forked as child, send output message via ipc to parent, otherwise output to console
 const logMessage = process.send ? process.send : console.log
 

packages/trail-hapi-plugin/lib/api.js

@@ -1,3 +1,5 @@
+'use strict'
+
 const { get } = require('lodash')
 const j2s = require('joi-to-swagger')
 

packages/trail-hapi-plugin/lib/schemas/trails.js

@@ -1,3 +1,5 @@
+'use strict'
+
 const config = require('config')
 const Joi = require('@hapi/joi')
 const j2s = require('joi-to-swagger')

packages/trail-hapi-server/lib/index.js

@@ -1,3 +1,5 @@
+'use strict'
+
 const Joi = require('@hapi/joi')
 const config = require('config')
 const { errorsSchemas } = require('@nearform/trail-hapi-plugin/lib/schemas/errors')

packages/trail-hapi-server/lib/swagger.js

@@ -1,3 +1,5 @@
+'use strict'
+
 const { readFileSync } = require('fs')
 const { join } = require('path')