This repository has been archived by the owner on Aug 19, 2022. It is now read-only.
Support publishing new udaru packages to npm #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed to add to release the postgres client.
…u, udaru-hapi-plugin -> @nearform/udaru-hapi-plugin
|
|
||
| ### Stand alone server | ||
| ``` | ||
| $ npx udaru |
There was a problem hiding this comment.
is npx correct?
There was a problem hiding this comment.
yes it is (see https://medium.com/@maybekatz/introducing-npx-an-npm-package-runner-55f7d4bd282b)
This is not tested though but the intent is to be able to run it via npx
cianfoley-nearform
approved these changes
Mar 22, 2018
mihaidma
reviewed
Mar 22, 2018
|
|
||
| 1) `udaru-core` - the core udaru library | ||
|
|
||
| 2) `udaru-hapi-plugin` - a plugin for Hapi that exposes a HTTP interface to `udaru-core` |
There was a problem hiding this comment.
Hapi should be written as hapi.js
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We will be publishing the 3 new packages as the following npm modules:
The existing npm.im/udaru module in npm will be used for the standalone server. The other two packages are new and will be published under the @nearform name space. (Thanks to @mcollina for advising on this).
The above naming convention also give us scope in the future for developing fastify or express http wrappers around core.
This PR supports the above, it's a combination of:
requirestatements everywhereudaru-coreaddedMore tidy up (particularly around documentation) to follow before we actually publish.