This repository has been archived by the owner on Aug 19, 2022. It is now read-only.
Added promises support to udaru-core. Removed udaru-test package. #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShogunPanda
force-pushed
the
promises-on-core
branch
from
a3da98d
to
7538666
Compare
|
Note: this is currently base after #506 by @cianfoley-nearform. Make sure to wait for it to be merged, then rebase after master before merging. |
Merged
ShogunPanda
force-pushed
the
promises-on-core
branch
from
7538666
to
030bec5
Compare
ShogunPanda
force-pushed
the
promises-on-core
branch
from
ef1f278
to
9db1334
Compare
dberesford
suggested changes
Mar 30, 2018
There was a problem hiding this comment.
One small nit but otherwise this is really great, thanks @ShogunPanda !
| console.log(`Migrations to ${version} done`, migrations) | ||
| }) | ||
| }) | ||
| .catch(err => { | ||
| console.log(err) |
There was a problem hiding this comment.
small nit: console.error(err)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The udaru-core has been modified to support async/await, but its still compatible with hapi v16.