Skip to content
This repository has been archived by the owner on Aug 19, 2022. It is now read-only.

batch access check for pairs of action/resources #540

Merged
merged 3 commits into from
May 17, 2018

Conversation

cianfoley-nearform
Copy link
Contributor

batch access takes a list of action/resource pairs and returns action/resource/access results

it probably would be worth building test case(s) using volume data for a large list of resources and actions to check to test speed

@coveralls
Copy link

coveralls commented May 16, 2018

Coverage Status

Coverage increased (+0.05%) to 93.228% when pulling 59f370b on batch-access-check into 5643068 on master.

Copy link
Contributor

@dberesford dberesford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

docs/overview.md Outdated
@@ -112,6 +112,7 @@ A brief overview of the Authorization API calls are as follows, see the live [Sw
|Path|Method|Summary|
|----|------|-------|
|/authorization/access/{userId}/{action}/{resource*}|GET|Authorize user action against a resource|
|/authorization/batchaccess/{userId}|POST|Authorize user actions against resources|
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wouldn't be better to say authorize a batch of user actions?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated route to just access and docs too :-)

@cianfoley-nearform cianfoley-nearform merged commit 4ce393a into master May 17, 2018
@cianfoley-nearform cianfoley-nearform deleted the batch-access-check branch May 23, 2018 08:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants