This repository has been archived by the owner on Aug 19, 2022. It is now read-only.
exact name search #543
Merged
exact name search #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihaidma
reviewed
May 18, 2018
| @@ -255,7 +255,8 @@ const teams = { | |||
| }, | |||
| searchTeam: { | |||
| organizationId: validationRules.organizationId, | |||
| query: requiredString | |||
| query: requiredString, | |||
| type: Joi.string().optional().allow('default', 'exact') | |||
There was a problem hiding this comment.
the name default for the partial search doesn't sound well to me, maybe pattern?
dberesford
suggested changes
May 18, 2018
|
@dberesford I'll fix conflicts and add docs in a commit and then merge... swagger was updated, but we can put in explicit section i usage? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rather than add a new endpoint, I added an optional type parameter to search, it defaults to our normal search mechanism, but when it is set to type=exact it will perform an exact name search.
we could put the same strategy in place for name search for users endpoint and policy endpoints if approved