Skip to content
This repository has been archived by the owner on Aug 19, 2022. It is now read-only.

Improve testing and coverage #578

Merged
merged 7 commits into from
Jul 30, 2019
Merged

Improve testing and coverage #578

merged 7 commits into from
Jul 30, 2019

Conversation

ovhemert
Copy link
Contributor

@ovhemert ovhemert commented Jul 1, 2019

Still a work in progress to add testing and improve coverage.
PR to let Travis process changes on coverage.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 93.461% when pulling 4e32a76 on improve-testing-and-coverage into 1708805 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 93.461% when pulling 4e32a76 on improve-testing-and-coverage into 1708805 on master.

@coveralls
Copy link

coveralls commented Jul 1, 2019 •
edited
Loading

Coverage Status

Coverage increased (+1.0%) to 94.086% when pulling 77ba85d on improve-testing-and-coverage into 1708805 on master.

@ovhemert ovhemert marked this pull request as ready for review July 4, 2019 14:19
@ovhemert ovhemert changed the title [WIP] Improve testing and coverage Improve testing and coverage Jul 4, 2019
dberesford
dberesford approved these changes Jul 30, 2019
View reviewed changes
Copy link
Contributor

@dberesford dberesford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @ovhemert

@dberesford dberesford merged commit 09cf319 into master Jul 30, 2019
@dberesford dberesford deleted the improve-testing-and-coverage branch July 30, 2019 16:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dberesford dberesford dberesford approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ovhemert @coveralls @dberesford