Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests for Wasm host-guest boundary #1292

Closed
MaksymZavershynskyi opened this issue Sep 10, 2019 · 3 comments
Closed

Tests for Wasm host-guest boundary #1292

MaksymZavershynskyi opened this issue Sep 10, 2019 · 3 comments
Assignees
@willemneal
Labels
A-transaction-runtime Area: transaction runtime (transaction and receipts processing, state transition, etc) C-good-first-issue Category: issues that are self-contained and easy for newcomers to work on. P-low Priority: low

Comments

@MaksymZavershynskyi
Copy link
Contributor

We need to make sure the unsafe code that wraps bindings both on guest and host side of Wasm operates with the data correctly (e.g. does not accidentally incorrectly read the passed blob).
@MaksymZavershynskyi MaksymZavershynskyi mentioned this issue Sep 10, 2019
Merged
@ilblackdragon ilblackdragon added the A-transaction-runtime Area: transaction runtime (transaction and receipts processing, state transition, etc) label Nov 29, 2019
@ilblackdragon ilblackdragon added this to the MainNet milestone Dec 8, 2019
@MaksymZavershynskyi
Copy link
Contributor Author

We now have tests for the boundary, but we should actually fuzz it.

@MaksymZavershynskyi MaksymZavershynskyi added P-low Priority: low and removed runtime-stability labels Jan 20, 2020
@MaksymZavershynskyi MaksymZavershynskyi added the C-good-first-issue Category: issues that are self-contained and easy for newcomers to work on. label Mar 19, 2020
@ilblackdragon ilblackdragon removed this from the MainNet milestone Mar 24, 2020
@stale
Copy link

stale bot commented Jul 1, 2021

This issue has been automatically marked as stale because it has not had recent activity in the last 2 months.
It will be closed in 7 days if no further activity occurs.
Thank you for your contributions.

@stale stale bot added the S-stale label Jul 1, 2021
@bowenwang1996
Copy link
Collaborator

I believe @matklad is already working on this. Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@willemneal willemneal

Labels
A-transaction-runtime Area: transaction runtime (transaction and receipts processing, state transition, etc) C-good-first-issue Category: issues that are self-contained and easy for newcomers to work on. P-low Priority: low
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@ilblackdragon @lexfrl @willemneal @bowenwang1996 @MaksymZavershynskyi