Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[documentation] Review QHub architecture diagram for Azure Provider #971

Closed
viniciusdc opened this issue Dec 14, 2021 · 7 comments
Closed
Assignees
Labels
area: documentation 📖 Improvements or additions to documentation needs: review 👀 This PR is complete and ready for reviewing

Comments

@viniciusdc
Copy link
Contributor

viniciusdc commented Dec 14, 2021

I have been trying to sketch a more detailed qhub architecture diagram for some of the services and integration (focusing on network traffic) that we deploy and create on Azure. I would love to have some feedback and any ideas are welcome.

QHub - Cloud architecture

The orange ones are optional features that can be enabled during deployment.

@viniciusdc viniciusdc self-assigned this Dec 14, 2021
@viniciusdc
Copy link
Contributor Author

Hi @trallard, if you have some time could you have a look ?

@viniciusdc viniciusdc changed the title [documentation] Review Qhub archirecture diagram for Azure Provider [documentation] Review QHub architecture diagram for Azure Provider Dec 14, 2021
@dharhas
Copy link
Member

dharhas commented Dec 14, 2021

Is Azure pipelines a requirement or optional. Can't we also use gilab runners, github actions?

@trallard
Copy link
Member

Should be optional - I would suggest replacing CI/CD (as a word) and add also icons for GH and GitLab

Same in container registry - Add the Docker logo (right now I can only see the ACR logo which might be misleading too)

Question @viniciusdc do the arrow colours and rectangles have a specific meaning (i.e authentication required, automated process) if so maybe add a legend on the side to clarify

@trallard trallard added area: architecture needs: review 👀 This PR is complete and ready for reviewing area: documentation 📖 Improvements or additions to documentation labels Dec 14, 2021
@viniciusdc
Copy link
Contributor Author

Should be optional - I would suggest replacing CI/CD (as a word) and add also icons for GH and GitLab

Hi @dharhas , the idea of using the Azure pipelines would be an optional feature in the case we are deploying using an Azure repo and not Github.

Same in container registry - Add the Docker logo (right now I can only see the ACR logo which might be misleading too)

For the container registry that's the registry where we store the images pulled during deploymeny and store to k8s use, docker or others can still be used independently.

Question @viniciusdc do the arrow colours and rectangles have a specific meaning (i.e authentication required, automated process) if so maybe add a legend on the side to clarify

Will do that, thanks 😄

@trallard
Copy link
Member

Hey @viniciusdc have you managed to make the above changes to the schematic?

Please post the diagram here when updated so we can add it to the docs

@costrouc
Copy link
Member

costrouc commented May 5, 2022

@viniciusdc do you mind giving an update on this issue and closing it with a PR.

@costrouc costrouc added this to the Release v0.4.2 milestone May 5, 2022
@kcpevey
Copy link
Contributor

kcpevey commented May 13, 2022

Closing in favor of #1031

@kcpevey kcpevey closed this as completed May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: documentation 📖 Improvements or additions to documentation needs: review 👀 This PR is complete and ready for reviewing
Projects
None yet
Development

No branches or pull requests

5 participants