Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing cdsdashboard conda environments being shown #1025

Merged
merged 1 commit into from Feb 4, 2022

Conversation

costrouc
Copy link
Member

@costrouc costrouc commented Feb 4, 2022

This is a short term fix for conda-store environments being shown in
cdsdashboards. Longer term we will need to consult the conda-store
rest api or filesystem for available environments (for 0.4.x release).

Fixes #1019

Changes:

  • added environments from qhub-config.yaml to cdsdashboards list.

Types of changes

What types of changes does your code introduce?

Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests?

  • Yes
  • No

This is a short term fix for conda-store environments being shown in
cdsdashboards. Longer term we will need to consult the conda-store
rest api or filesystem for available environments (for 0.4.x release).

Fixes #1019
@iameskild iameskild self-requested a review February 4, 2022 15:15
Copy link
Member

@iameskild iameskild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on our conversation yesterday, this looks good to me! Thanks @costrouc!!

@iameskild iameskild merged commit 25b2eaa into main Feb 4, 2022
@costrouc costrouc deleted the fix-1019-cdsdashboards branch August 23, 2022 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] Populate available conda environment for cdsdashboards and launch dashboards successfully
2 participants