Additions to TCP/DNS stage check, fix 1027 #1063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
February 8, 2022 09:53
iameskild
commented
Feb 15, 2022
| @@ -459,6 +468,7 @@ def _attempt_tcp_connect(host, port, num_attempts=3, timeout=5): | |||
| } | |||
| ip_or_name = stage_outputs[directory]["load_balancer_address"]["value"] | |||
| host = ip_or_name["hostname"] or ip_or_name["ip"] | |||
| host = host.strip("\n") | |||
There was a problem hiding this comment.
There appears to be a newline character at the end of host for a reason I have yet to figure out.
There was a problem hiding this comment.
This should be fine. If the newline for some reason doesn't exist in the future, this won't cause any problems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes | Closes | Resolves #1027
Changes:
Increase the timeout and attempts to ensure that TCP and DNS checks pass before moving on.
Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that applyTesting
Requires testing
In case you checked yes, did you write tests?
Further comments (optional)
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered and more.