Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC]- Update contribution guidelines #1080

Merged
merged 4 commits into from Feb 25, 2022

Conversation

trallard
Copy link
Member

@trallard trallard commented Feb 18, 2022

Fixes #1078

Changes:

  • Removes references to main
  • Adds more details on how to contribute
  • Adds extra --- to RELEASE.md to make it easier to read

Types of changes

What types of changes does your code introduce?

Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests?

  • Yes
  • No

Further comments (optional)

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered and more.

@trallard trallard added the needs: review 👀 This PR is complete and ready for reviewing label Feb 21, 2022
Copy link
Member

@costrouc costrouc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@trallard looks great to me. Vale checks are a little too strict

@costrouc costrouc merged commit 6846960 into nebari-dev:main Feb 25, 2022
@trallard trallard deleted the trallard/contributing branch February 25, 2022 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: review 👀 This PR is complete and ready for reviewing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOC] - Improve GitHub contribution guidelines
2 participants