Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganizing render, deploy, destroy to unify stages input_vars, tf_objects, checks, and state_imports #1091

Merged
merged 3 commits into from Feb 22, 2022

Conversation

costrouc
Copy link
Member

@costrouc costrouc commented Feb 22, 2022

This PR is only a refactor of render, deploy, and destroy. The motivation for this is allowing for the closing of #1081. In order to properly delete the aws ingress we need to be able to get the terraform outputs from some early kubernetes stages. This PR will also allow for the easier transition to #865.

There are no modifications to the behavior of the code.

Going into more detail about the heart of the issue:

For each stage we have to supply input variables, dymanic terraform objects, terraform imports.

We cannot run terraform output without supplying the proper input variables. Within deploy.py and destroy.py this was becoming repetative. Thus I've moved the definitions into a stages/*.py directory which will need to be done with whatever extension mechanism we chose.

tf_objects, checks, and state_imports

Closes #1081
Copy link
Contributor

@danlester danlester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great step forward!

At some point maybe we will refactor using classes to enforce the structure and reduce repetition of strings such as stages/03-kubernetes-initialize.

@danlester danlester merged commit 5ba9746 into main Feb 22, 2022
@iameskild iameskild deleted the fix-1081 branch August 18, 2022 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants