Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Keycloak docs #1093

Merged
merged 25 commits into from Feb 28, 2022
Merged

Update Keycloak docs #1093

merged 25 commits into from Feb 28, 2022

Conversation

iameskild
Copy link
Member

Fixes | Closes | Resolves #999

Please remove anything marked as optional that you don't need to fill in. Choose one of the keywords preceding to refer to the issue this PR solves, followed by the issue number (e.g Fixes # 666). If there is no issue, remove the line. Remove this note after reading.

Changes:

  • Update docs based on new default groups available

Types of changes

What types of changes does your code introduce?

Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests?

  • Yes
  • No

Further comments (optional)

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered and more.

@trallard trallard added the needs: review 👀 This PR is complete and ready for reviewing label Feb 22, 2022
docs/source/installation/login.md Outdated Show resolved Hide resolved
docs/source/installation/login.md Outdated Show resolved Hide resolved
docs/source/installation/login.md Show resolved Hide resolved
docs/source/installation/login.md Outdated Show resolved Hide resolved
docs/source/installation/login.md Outdated Show resolved Hide resolved
docs/source/installation/login.md Outdated Show resolved Hide resolved
docs/source/installation/login.md Outdated Show resolved Hide resolved
docs/source/installation/login.md Outdated Show resolved Hide resolved
docs/source/installation/login.md Outdated Show resolved Hide resolved
docs/source/installation/login.md Outdated Show resolved Hide resolved
@trallard trallard added the needs: changes 🧱 Review completed - some changes are needed before merging label Feb 22, 2022
iameskild and others added 10 commits February 25, 2022 11:33
Co-authored-by: Tania Allard <taniar.allard@gmail.com>
Co-authored-by: Tania Allard <taniar.allard@gmail.com>
Co-authored-by: Tania Allard <taniar.allard@gmail.com>
Co-authored-by: Tania Allard <taniar.allard@gmail.com>
Co-authored-by: Tania Allard <taniar.allard@gmail.com>
Co-authored-by: Tania Allard <taniar.allard@gmail.com>
Co-authored-by: Tania Allard <taniar.allard@gmail.com>
Co-authored-by: Tania Allard <taniar.allard@gmail.com>
Co-authored-by: Tania Allard <taniar.allard@gmail.com>
Co-authored-by: Tania Allard <taniar.allard@gmail.com>
@iameskild
Copy link
Member Author

Hey @trallard, thanks for the thorough review. I committed all but one of your suggestions. I will be making updates here based on some of the recent keycloak group changes (#1112). I'd be happy to have you look it over again shortly :)

@iameskild iameskild removed the needs: changes 🧱 Review completed - some changes are needed before merging label Feb 25, 2022
docs/source/installation/login.md Outdated Show resolved Hide resolved
docs/source/installation/login.md Outdated Show resolved Hide resolved
docs/source/installation/login.md Outdated Show resolved Hide resolved
docs/source/installation/login.md Outdated Show resolved Hide resolved
docs/source/installation/login.md Outdated Show resolved Hide resolved
docs/source/installation/login.md Outdated Show resolved Hide resolved
docs/source/installation/login.md Outdated Show resolved Hide resolved
docs/source/installation/login.md Outdated Show resolved Hide resolved
docs/source/installation/login.md Outdated Show resolved Hide resolved
@trallard trallard added needs: changes 🧱 Review completed - some changes are needed before merging and removed needs: review 👀 This PR is complete and ready for reviewing labels Feb 25, 2022
@costrouc
Copy link
Member

This keycloak group structure is finalized so should be ready for the keycloak docs.

iameskild and others added 4 commits February 26, 2022 16:30
Co-authored-by: Tania Allard <taniar.allard@gmail.com>
Co-authored-by: Tania Allard <taniar.allard@gmail.com>
Co-authored-by: Tania Allard <taniar.allard@gmail.com>
Co-authored-by: Tania Allard <taniar.allard@gmail.com>
iameskild and others added 4 commits February 26, 2022 16:32
Co-authored-by: Tania Allard <taniar.allard@gmail.com>
Co-authored-by: Tania Allard <taniar.allard@gmail.com>
Co-authored-by: Tania Allard <taniar.allard@gmail.com>
Co-authored-by: Tania Allard <taniar.allard@gmail.com>
@iameskild iameskild added needs: review 👀 This PR is complete and ready for reviewing and removed needs: changes 🧱 Review completed - some changes are needed before merging labels Feb 27, 2022
Copy link
Member

@trallard trallard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking much better now 🎉

docs/source/installation/login.md Outdated Show resolved Hide resolved
docs/source/installation/login.md Outdated Show resolved Hide resolved
docs/source/installation/login.md Show resolved Hide resolved
iameskild and others added 3 commits February 28, 2022 17:21
Co-authored-by: Tania Allard <taniar.allard@gmail.com>
Co-authored-by: Tania Allard <taniar.allard@gmail.com>
Co-authored-by: Tania Allard <taniar.allard@gmail.com>
@iameskild
Copy link
Member Author

Thanks for all your help @trallard! I think this is ready for one final look-over whenever you get the chance :)

@iameskild iameskild merged commit e6302f5 into main Feb 28, 2022
@iameskild iameskild deleted the keycloak_docs_eae branch February 28, 2022 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: review 👀 This PR is complete and ready for reviewing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[documentation] Keycloak docs
3 participants