Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change AWS Kubenetes provider authentication to use data.eks_cluster instead of exec #1107

Merged
merged 3 commits into from Feb 23, 2022

Conversation

costrouc
Copy link
Member

Fixes | Closes | Resolves #1106

Changes introduced in this PR:

  • this PR changes the aws credentials from being stored and used by each stage to instead being fetched each time the kubernetes provider is used (using data).

This follows best practices outlined in https://github.com/hashicorp/terraform-provider-kubernetes/tree/main/_examples/eks. Later we may want to adopt this for other clouds.

Types of changes

These changes should not add or remove any features.

Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

@costrouc costrouc changed the title Fix 1106 Change AWS Kubenetes provider authentication to use data.eks_cluster instead of exec Feb 23, 2022
@costrouc costrouc merged commit 53f91d9 into main Feb 23, 2022
@costrouc costrouc deleted the fix-1106 branch February 23, 2022 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - AWS Kubernetes Credentials Expired
1 participant