Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing bug in authentication method in Conda-Store authentication #1396

Merged
merged 1 commit into from
Aug 17, 2022
Merged

Fixing bug in authentication method in Conda-Store authentication #1396

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...-kubernetes-services/modules/kubernetes/services/conda-store/config/conda_store_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ def conda_store_config(path="/var/lib/conda-store/config.json"):


class KeyCloakAuthentication(GenericOAuthAuthentication):
def authenticate(self, request):
async def authenticate(self, request):
# 1. using the callback_url code and state in request
oauth_access_token = self._get_oauth_token(request)
if oauth_access_token is None:
Expand Down Expand Up @@ -114,7 +114,7 @@ def authenticate(self, request):
namespaces.add(group_name)
role_bindings[f"{group_name}/*"] = roles

conda_store = get_conda_store()
conda_store = get_conda_store(request)
for namespace in namespaces:
_namespace = api.get_namespace(conda_store.db, name=namespace)
if _namespace is None:
Expand Down